Updating for agent0 and various cleanup #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryangoree
approved these changes
Jun 12, 2024
This was referenced Jun 12, 2024
mcclurejt
reviewed
Jun 18, 2024
| profiles: | ||
| - "service-bot" | ||
| command: | | ||
| /bin/sh -c "sleep 1; python scripts/checkpoint_bots.py --pool-check-sleep-blocks 30 --infra" |
There was a problem hiding this comment.
kinda curious why we need the sleep?
mcclurejt
reviewed
Jun 18, 2024
| @@ -1,4 +1,3 @@ | |||
| version: "3.9" | |||
mcclurejt
reviewed
Jun 18, 2024
| @@ -15,7 +14,7 @@ services: | |||
| profiles: | |||
| - "data" | |||
| working_dir: /app/ | |||
| command: /bin/sh -c "python scripts/run_data_analysis.py" | |||
| command: /bin/sh -c "python scripts/run_analyze_data.py" | |||
mcclurejt
reviewed
Jun 18, 2024
Comment on lines
8
to
+10
| POSTGRES_PASSWORD: password | ||
| POSTGRES_USER: admin | ||
| POSTGRES_DB: postgres_db | ||
| POSTGRES_DB: agent0_db |
There was a problem hiding this comment.
do we wanna pull these from the .env file instead of redefining them here?
mcclurejt
reviewed
Jun 18, 2024
| @@ -1,5 +1,5 @@ | |||
| POSTGRES_USER=admin | |||
| POSTGRES_PASSWORD=password | |||
| POSTGRES_DB=postgres_db | |||
| POSTGRES_DB=agent0_db | |||
There was a problem hiding this comment.
nit: if we expect to have more than one db present on the postgres instance, we might want to indicate that by changing the env variables in the .env file.... for example
# .env
AGENT0_POSTGRES_USER=admin
AGENT0_POSTGRES_PASSWORD=password
AGENT0_POSTGRES_DB=agent0_db
MY_POSTGRES_USER=me
MY_POSTGRES_PASSWORD=yo
MY_POSTGRES_DB=my_dbthen in the compose file....
environment:
POSTGRES_PASSWORD: $AGENT0_POSTGRES_PASSWORD
POSTGRES_USER: $AGENT0_POSTGRES_USER
POSTGRES_DB: $AGENT0_POSTGRES_DBmight need to pass as args rather than env vars since I'm not sure if .env vars will be interpolated but hopefully the gist makes sense
mcclurejt
reviewed
Jun 18, 2024
| echo " --postgres : Runs a postgres db container for storing data." | ||
| echo " --data : Runs the data framework, querying the chain and writing to postgres." | ||
| echo " --service-bot : Runs checkpoint bot and invariance check bots on the chain." | ||
| echo " --random-bot : Runs random bots on the chain." |
There was a problem hiding this comment.
kinda confused as to what a "random" bot is in this case...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup_env.setup_env.